..hj #1
Open
..hj #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename IUserDataWebSocketClientManager and add comments.
Include system status check and indefinite delay during maintenance.
BREAKING: Change TimeInterval properties from long to DateTime and change StartTime to BeginTime. Make TimeInterval IChronological using BeginTime.
BREAKING: Change IBinanceApi and IBinanceHttpClient GetDepositsAsync() and GetWithdrawalsAsync() timestamp parameters to DateTime. Make asset parameter optional.
No namespace/code changes.
BREAKING: Change namespace from Binance to Binance.Api for HTTP client, rate limiter, and timestamp provider interfaces as well as related classes. For #122.
BREAKING: Change namespace from Binance to Binance.Api for HTTP client, rate limiter, and timestamp provider interfaces as well as related classes. For #112.
Do not add 10000 limit to comment since it was temporarily removed -- 2019-08-16 (Update 2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<....